Manage landing page using flexbox, grid, sass, vanilla js

Community feedback

• Account deleted

  clicking the hamburger then going back to desktop does not dismiss the mobile menu, should be an easy fix. Otherwise everything looks great.

  2

  ---

  

  Abhijit Barman•550

  @abhijitbcobPosted over 3 years ago

  @thulanigamtee thank you! now I have fixed that issue. Your feedback also helped me to find another issue that was unresponsive carousel and I fixed it too.

  0
• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Abhijit Barman! 👋

  Congrats on finishing another challenge! 🎉 Your solution looks very good and also responds well. Here's my few tips:

  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
  • Change the alt attributes for the .hero__img and avatars images, as they don't add any extra context for screen reader users. Since your images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Abhijit Barman•550

  @abhijitbcobPosted over 3 years ago

  @tediko thank you for your tips. Really :focus is so important for accessibility. Now, I have updated my code as you said.

  0
• 

  Mohammed Nadeem Shareef•165

  @shareef99Posted over 3 years ago

  Great Work brother! I love it

  1

  ---

  

  Abhijit Barman•550

  @abhijitbcobPosted over 3 years ago

  @shareef99 thank you brother!

  0