Manage landing page

Community feedback

• 

  Rohith Suresh•65

  @rohith-23-creatorPosted about 3 years ago

  Hy Oliver. Great job. My feedback is, when hamburger menu is pressed, the menu hides the button in mobile view Second is, overflow happens when zoomed so u can use OverflowX hidden to main container to solve this. Thanks

  0
• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted almost 4 years ago

  Hey Oliver, looks good! I just noticed that the buttons all have a pseudoelement ::after. Not sure what it's for but you can easily apply :hover states directly to the button if that was the issue.

  For the backgrounds, yes they were quite challenging for this project. I think I used a combination of percentage and rem units to keep them in place. I would take advantage of the hubs if I were you, and check other solutions there for ideas.

  To make things easier, I used a package for the slider section. There's a few choices out there but I ended up using Swiper.

  Lastly for the email input, the site breaks when I enter an email with or without a .something at the end. The js would need an adjustment.

  Hope this helps :-)

  2

  ---

  

  Oliver Sagala•120

  @sagspotPosted almost 4 years ago

  @emestabillo Ops! I hadn't noticed the issue with the email. Am also curious to know how you achieve the whitish effect on your button on hover. You have link to your code?

  1

  

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted almost 4 years ago

  @sagspot Sure, here’s the submission page

  0
• 

  Kofi Nartey•650

  @kofinarteyPosted almost 4 years ago

  Wow man. I love your work. Unfortunately I'm not so adept at JS and SASS to know what's going on here. But I must say that it is pretty impressive. Good job

  1

  ---

  

  Oliver Sagala•120

  @sagspotPosted almost 4 years ago

  Thank you @kofinartey I try to make it easier to manage by separating my files

  0