@cessnar516
Posted
Great job, Robert! Your page is responsive, and I like that you used CSS grid to create the desktop layout. One thing you could do differently would be to use semantic HTML elements for as much of your layout as possible instead of using divs. For example, right now all of your cards are divs. Instead, you could make each card an <article>
element. The top color can be added to the card using border-top
, so you wouldn't need the <div class = "top-color">
anymore, and then you could add your padding to the card itself instead of needing the <div class = "content">
. This would leave you with a <article>
element containing an <h3>
, <p>
, and <img>
- no more divs!
Hope this helps!
Marked as helpful
@R0b3rtG
Posted
@cessnar516 Thank you very much, I'll try to do so!