Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Made using HTML, CSS basics, Flexbox, Grid and mobile-first design

@R0b3rtG

Desktop design screenshot for the Four card feature section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please leave some feedback! :)

I would really appreciate it!

:)

Community feedback

@cessnar516

Posted

Great job, Robert! Your page is responsive, and I like that you used CSS grid to create the desktop layout. One thing you could do differently would be to use semantic HTML elements for as much of your layout as possible instead of using divs. For example, right now all of your cards are divs. Instead, you could make each card an <article> element. The top color can be added to the card using border-top, so you wouldn't need the <div class = "top-color"> anymore, and then you could add your padding to the card itself instead of needing the <div class = "content">. This would leave you with a <article> element containing an <h3>, <p>, and <img> - no more divs!

Hope this helps!

Marked as helpful

0

@R0b3rtG

Posted

@cessnar516 Thank you very much, I'll try to do so!

0
dewslyse 3,025

@dewslyse

Posted

Hi Robert. Congrats on your submission. Your page looks good and is responsive. You could add aria-hidden: true to your imgs for improved accessibility since they're purely decorative.

All the best with subsequent challenges.

0

@R0b3rtG

Posted

@dewslyse Thank you very much for your feedback

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord