Made using HTML, CSS basics, Flexbox, Grid and mobile-first design

Community feedback

• 

  Rachel Cessna•195

  @cessnar516Posted about 3 years ago

  Great job, Robert! Your page is responsive, and I like that you used CSS grid to create the desktop layout. One thing you could do differently would be to use semantic HTML elements for as much of your layout as possible instead of using divs. For example, right now all of your cards are divs. Instead, you could make each card an <article> element. The top color can be added to the card using border-top, so you wouldn't need the <div class = "top-color"> anymore, and then you could add your padding to the card itself instead of needing the <div class = "content">. This would leave you with a <article> element containing an <h3>, <p>, and <img> - no more divs!

  Hope this helps!

  Marked as helpful

  0

  ---

  

  Robert Iancu•0

  @R0b3rtGPosted about 3 years ago

  @cessnar516 Thank you very much, I'll try to do so!

  0
• 

  dewslyse•3,025

  @dewslysePosted about 3 years ago

  Hi Robert. Congrats on your submission. Your page looks good and is responsive. You could add aria-hidden: true to your imgs for improved accessibility since they're purely decorative.

  All the best with subsequent challenges.

  0

  ---

  

  Robert Iancu•0

  @R0b3rtGPosted about 3 years ago

  @dewslyse Thank you very much for your feedback

  0