Design comparison
Solution retrospective
Hello, everybody! 👋
Let me know if my code could be better!😊 Feedback is welcome and appreciated! 😊
Happy coding! 😁
Community feedback
- @GrzywNPosted over 2 years ago
Great job 👏
I suggest using
rem/em
units instead ofpx
. Rems/ems are better if the user uses custom browser font size or somebody is using a device which handles px differently (for some devices 3px or 2px are 1px). It's generally a good practice to use them everywhere, even breakpoints. You can also download px to rem extension for VS Code.Have a nice day and keep coding 😁
Marked as helpful1@Luis15HerrPosted over 2 years ago@GrzywN I will keep it in mind for the next development, thank you 😁
1 - @josemgfortunatoPosted over 2 years ago
Hey Luis,
The responsive menu style didn't fit on 375px screen. The X (output) icon is extrapolating the screen to the right side. I think you should do some css adjusts for the @media screen. I think you did an impressive job. Creative and inspiring. The pattern colors and the concept are great. Good job bro!
Marked as helpful0@Luis15HerrPosted over 2 years ago@josemgfortunato Thanks for the comment, I'll correct it
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord