Layout with regex, grid, flexbox, so much position absolute and linear
Design comparison
Solution retrospective
So, why have a little overflow-x in navigation mobile? I try debug that weird feature but I don't reach
Community feedback
- @skyv26Posted almost 3 years ago
Hi! Hendrick, you did it nicely. I saw and in my view you know JS but have problem with CSS.
as I saw Email Address placeholder is not aligned to center in input field. and your desktop views need some changes in order to make it look more better.
Answer to your question
You design have little overflow-x in navigation mobile because of below CSS Rule
.box-img { background-image: url(images/hero-desktop.jpg); background-size: cover; }
You used it and it is ok but you should be aware of using above approach, by default image repeat itself in order to fill the space. Make a little bit change in above and your issue will be solve
Do
.box-img { background-image: url(images/hero-desktop.jpg); background-repeat: no-repeat; background-size: cover; }
It will solve your issues.
I hope you understand and if there's any doubt then I am always here and slack community will also help you.
Good Luck
Marked as helpful0@HendrickGHPosted almost 3 years ago@skyv26 Great, thank you very much, The strange error was automatically fixed when I saw it on my phone and others phones, but your advice is usueful because I know the backgroud-repeat property but I didn't know it generating overflow-x.
1@HendrickGHPosted almost 3 years ago@skyv26 and what problems do I have with CSS? To improve 🤗
1@skyv26Posted almost 3 years ago@HendrickGH Well I haven't see your whole CSS code I just figured out the issues and told you why the issues occured ! I will see some more work of you and let you know where you need improvement.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord