Landing page using CSS Flexbox for desktop and phone display

Community feedback

• 

  Fidel Lim•2,775

  @fidellimPosted about 3 years ago

  Hi Rizqy,

  Great work on this project! There are just some points I would like to share:

  • You should remove overflow-y: hidden; on mobile view as you won't be able to scroll the page all the way down.
  • Try to check the view of the page as you change from desktop to mobile view. There will be a point wherein the component is not seen well. So, try to change the width for your media query.
  • Try to have a look at mobile-first approach when starting a project. With this approach, you start first with mobile view then desktop view. Have a look at this link if you are interested: mobile-first approach

  I guess that is about it. I hope it helps :)

  Marked as helpful

  0

  ---

  

  Rizqy Fachri•110

  @RizqyfmPosted about 3 years ago

  @fidellim

  Hi Fidel, First of all, thank you for your feedback and suggestions

  • I think I forgot to remove the overflow-y on mobile view, thanks for noticing :)

  • I see, seems like adapting a mobile-first approach is a good way to make the site 100% responsive. Thanks for the link and I will read it for sure. :)

  Again, thanks!

  1

  

  Fidel Lim•2,775

  @fidellimPosted about 3 years ago

  @Rizqyfm You're welcome! Good luck with your future projects!

  0
• 

  Muhammad Shajjar•1,100

  @muhammadshajjarPosted about 3 years ago

  Hi congrats on completing your third FEM solution, you succeeded in similarity, some suggestions that would help you

  • By giving width on illustration-Image, it causes a horizontal scrollbar at some viewports, use max-width instead
  • Add max-width to a body or make a container class that wraps your all content, by adding it you can control your content from growing too much on larger viewports
  • The logo should be in anchor a, logos are used to navigate on the home page in most the cases
  • always have a look at the report, it helps you to overcome accessibility and HTML issues

  Happy coding :)

  Marked as helpful

  0

  ---

  

  Rizqy Fachri•110

  @RizqyfmPosted about 3 years ago

  @muhammadshajjar

  Hi Muhammad Shajjar! Thanks for your feedback and suggestions

  Max-width, the anchor, and the report! Got it!

  Once again, thank you!

  0