landing page using css flex and grid but it is not resposive

Community feedback

• 

  Boluwatife Bonaventure•550

  @BoyutifePosted over 1 year ago

  Hello ASHISH KUMAR SHARMA 👋. Congratulations on successfully completing the challenge! 🎉

  I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  Use the main semantic tag instead of section

  CSS 🎨:

  Use relative units like rem or em as the unit for the padding, margin, and width values, and preferably rem for the font-size values, instead of px, which is an absolute unit. Instead of 500px, you can replace it with 32rem.

  You can try more of flexbox properties instead of position properties

  Use media query for responsive design.

  You can include grid-template row: 1fr 1fr 1fr ; this way

  @media (max-width: 370px) {
    .main-container {
             display: grid;
             grid-template-rows: 1fr 1fr 1fr;
            }
        }
  

  BODY MEASUREMENTS 📐:

  Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh.

  But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  Feel free to ask for further assistance and clarification

  I hope you find this helpful 😄 Above all, the solution you submitted is great ! Happy coding!

  Marked as helpful

  0