Landing page, dark mode and email validation

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, TrakaMeitene! 👋

  Congratulations on finishing another challenge! What i would suggest is:

  • You set your font-size to view width. This is causing that on my resolution 1920px x 1080px font-sizes are huge. Try to fix that.
  • Since your .logo, Intro illustration, logs images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers.
  • Your site logo isn't clickable. It'd be a good idea to make the page refresh or scroll to the top when you click it. If you change it to be clickable, you can keep your alternative text on that element, but change it to maybe "Huddle - home page" or something similar.
  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
  • Add some aria-labels for your soc anchor tags to let screen readers know what kind of link is that.

  Good luck with that, have fun coding! 💪

  2

  ---

  

  TrakaMeitene•505

  @TrakaMeitenePosted over 3 years ago

  @tediko Thank you very much for your feedback.

  Ha, I did thought about the border on my input element, tried to make it dissapear, but my son interrupted me and I forgot to take deeper research on it. Thank you :)

  0