Landing on small screens w/o frameworks

Community feedback

• 

  Roman Filenko•3,335

  @rfilenkoPosted about 4 years ago

  Hey Nocolas, nice work. Some other suggestions how to improve:

  • wriite more semantic html tags (footer should be footer tag, a list of icons - also list of links, etc);
  • add desktop version using mediaqueries;
  • hover on burger menu isn't a proper way to show a menu - make it on click, just few lines in js;
  • in .insurance__text section - with z-index: -5 you can't really click a link;

  Keep practicing, Roman

  0
• 

  Anil Pak•155

  @anlpkPosted about 4 years ago

  Hi Nicolas,

  There are several problems, *Firstly, you should not use that many br tags, (All this br tags breaking your code.) Secondly, when you start style your css follow the same flow with html and write some comment on the top such as, / Header Font Style / or / Footer Flex Box */ After for a while it is so hard to read the code and also you will spend so much time to fix it. And always start with mobile approach first and then move to different screen size it will make your life much easier.

  0