Job listings with filtering using JS vanilla, SASS and BEM

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Yaiza! 👋

  Well done on this challenge! Your solution responds well. Here's my suggestion:

  • Use <button> element for .card-filter instead of divs since they trigger some action.
  • .card-data__item text is wrapping. I think you have to set bigger width for that elements.

  Good luck with that, have fun coding! 💪

  0

  ---

  

  Yaiza•410

  @Yaiza16Posted over 3 years ago

  @tediko Hello, tediko! Thanks for your feedback! I really appreciate it

  I have a question related to it:

  What is the difference between use <button> or <div ? I mean, don't they both work anyway?

  0

  

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  @Yaiza16 In general, choose the tag that most closely describes the function of its content, not the appearance of its content, and avoid unnecessary <div> tags lest your documents suffer from divitis.Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.

  0