Design comparison
Solution retrospective
Hello, Frontend Mentor community! This is my solution to the IP address tracker.
I have read all the feedback on this project and improved my code. Due to the fact that I published this project very long ago, I am no longer updating it and changing its status to Public Archive on my Github.
You are free to download or use the code for reference in your projects, but I no longer update it or accept any feedback.
Thank you
Community feedback
- @jpdrsanchezPosted about 3 years ago
Nice work on this challenge, your solution looks good and works well.
I'd add the meta tag
<meta charset="utf-8">in yourindex.html.I'd also do a validation on the search input to only allow IP addresses in it.
But it's just small details
Keep it up!
Marked as helpful1@catherineisonlinePosted about 3 years ago@jpdrsanchez Meta is already there on the line 5. Yeah, validation is a great idea, thanks
0 - @hctmanuelortizPosted about 3 years ago
Excellent work!!!
0 - @KNWardPosted about 3 years ago
This look great! Great job.
0 - @Qstar12Posted about 3 years ago
Looks great! Hopefully I'll be tackling this one soon. Keep up the great work.
0 - @SK1202Posted about 3 years ago
@catherineisonline Wow!! API ... Great job
0 - @ajormosesPosted about 3 years ago
You are already working on API... Progress
0@catherineisonlinePosted about 3 years ago@ajormoses Trying my best, thank you!
0 - @Zein-MBPosted about 3 years ago
Hey Catherine I have a note about the cursor of the input, if you can make it "text" so that'd be better than "pointer", Good job! and have a good day. Regards.
0 - @ayushbhargava22Posted about 3 years ago
Great UI 🎉
0 - @nonso01Posted about 3 years ago
just 👌👌👌💯! am jealous 😑! that's some smooth work!
0 - @MishalZiaPosted about 3 years ago
Hi @catherineisonline,
Good job on this challenge, it's amazing.
0 - @ChamuMutezvaPosted about 3 years ago
I am using Google Chrome on an android phone (Huawei)
0 - @ChamuMutezvaPosted about 3 years ago
Hi Catherine
Your solution looks good, well done. Here are some of my observations:
- Input elements should be associated with labels, a placeholder is good but cannot be a replacement for a label.
- I cannot type in the input field on my mobile, the modal is getting in way blocking the entire field.
0@catherineisonlinePosted about 3 years ago@ChamuMutezva Thank you for the feedback! By the way, which mobile and browser did you use?
0 - @aladin002dzPosted about 3 years ago
Excellent work! 👏✨I learned from your excellent "readme" file too ✨, I will use "Perfect Pixel" for my next projects, thanks for sharing in this clear, nice, and beautiful way!🙏 You can hide the "API Key" or any other, eventually, sensitive data by using environment variables and deploying on Vercel on Netlify, instead of GitHub pages. https://vercel.com/docs/concepts/projects/environment-variables https://docs.netlify.com/configure-builds/environment-variables/ Looking forward to seeing your next project!
0@catherineisonlinePosted about 3 years ago@aladin002dz Thank you! I will take a look
0 - @KasraTabriziPosted about 3 years ago
Nice job!
Only one issue: The map and info doesn't change when searching for a different IP address. It always shows the default one from Georgia.
0@catherineisonlinePosted about 3 years ago@KasraTabrizi That's what I am working on right now. The API ran out of requests and it's not free so I am in the process of changing to a different API right now.
0 - @felipesoarwsPosted about 3 years ago
Nice work! Well done!
Just one thing, in the top, it's ''adress'' instead of ''address'', but the rest it's perfect!
0@catherineisonlinePosted about 3 years ago@felipesoarws Thanks! Didn't even notice
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord