Invoice App using Svelte and Firebase with custom datepicker

Community feedback

• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted over 3 years ago

  Hey @grizhlieCodes, looks great! Really like the smooth transitions. I'm not able to create a new user because when I click sign out, I only get a brief glimpse of the sign up page and reloads right away. I also can't click on the svgs inside Input Date and Payment Terms. The buttons Save as Draft and Save and Send that appear at the bottom of the create modal looks a little squished on mobile. Real good job though!

  1

  ---

  

  Rafal•1,395

  @grizhlieCodesPosted over 3 years ago

  @emestabillo Ahhh, I had to create a temporary 'auto-login' solution so that Frontend Mentor screenshot would be taken.

  This was removed probably minutes after you checked out the project 😥, timing wasn't on my side!

  Thanks for the feedback, will review the mobile styling. I'll admit I spent most of the time on the desktop version.

  1
• 

  Simon Davis•505

  @SkidragonPosted over 3 years ago

  It looks and animates pretty awesome! The only suggestions I have is the confirm deletion modal could be exited out of when pressing esc and just being more keyboard accessible. Also the fields for creating an invoice could have more validation like the email and having an autocomplete fields for the state and city but MVP wise it's pretty solid. Keep up the good work and grit! I might look at the code base more tomorrow when I have more time. Also I'm doing the audiophile guru one to challenge myself too.

  1

  ---

  

  Rafal•1,395

  @grizhlieCodesPosted over 3 years ago

  @Skidragon I agree with all suggestions, especially on the more 'validate' aspects.

  Let me explain my thinking, especially for the email field.

  I was to create the application (a real life one) I would have a more robust fallback. Not sure what but let's take login as an example of what I mean by 'robust': best way to validate an email is with 'Confirm your email' functionality. Otherwise it could be correct syntactically but incorrect overall. Also I think I got lazy when thinking to add some regex 😅. But lets ignore my laziness and stick with the cooler answer??

  As for the ESC/click out/etc, totally. I don't think I'll end up adding it in this project now as it's probably best to move on and keep that behaviour planned out for the next project. I think I'll follow your footsteps and do the audiophile guru project next 😁. I need a way to better keep a track of all the functionality I want to add. Probably time to get back on the Notion-mobile (great app if you haven't used it)...

  Thanks for taking the time to review this project. I'll have a looksie at some of yours over the next few days.

  1

  

  Simon Davis•505

  @SkidragonPosted over 3 years ago

  @grizhlieCodes I agree on the email points you made, and I get lazy too lol and just say MVP to be finished with something I'm tired with but at least I finish the project. I do use Notion as a note taker but didn't know they had a mobile app, and Anki for flashcards to remember concepts with memory techniques. I'm going to fork your project if you don't mind and play with it a little since I never used Svelte before but it is interesting. I'm going to get that modal keyboard accessible. :p

  1

  

  Rafal•1,395

  @grizhlieCodesPosted over 3 years ago

  @Skidragon Oi, looks like you did it! Neato. I haven't really used any tool like Anki cards to memorise concepts, might give it a shot when learning some new.

  Svelte to me seems to outline how over-the-top frameworks get overtime. Also it hasn't changed much over the last 2 years. The new tool (currently beta) SvelteKit is basically what Next.js is to React. So you're able to do routing, server-side rendering etc from 1 tool. Best part is that everything you learn in Svelte is still applicable so no relearning. And Svelte compiles all your code to vanilla JS at build-time so you end up building really small applications.

  As you can tell I'm somewhat of a fanboy at this point.

  0