Intro page with dropdown menus

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  Looks cool. 😎 Instead of creating a background color div, you can simply apply the color to the body. The logo icon ideally should be inside the navigation or header, not just a separate entity. Same for the separate image in the main tag, you can make the image part of the article because it's part of it. Also, for the desktop, when I click on the "Company" menu it affects the position of the positions of items on the right, might want to fix that part.

  I hope this helps 😊

  Marked as helpful

  1

  ---

  

  Kathryn•320

  @KathrynDavies123Posted almost 2 years ago

  @catherineisonline Thanks for the advice!

  0

  

  Kathryn•320

  @KathrynDavies123Posted almost 2 years ago

  @catherineisonline Hi again, adding the color to the body didn't work, it looked really strange, too dark even if I added opacity and it was "behind" the content of the page when I wanted it infront of it. Could you share a code snippet of how this should work? Thanks

  0
• 

  Yehan Nilanga•670

  @Yehan20Posted almost 2 years ago

  Hello there you solution looks awesome and clean , congratulations. For the register and learn more buttons , I think having an <a> tag would be fine because in a real use case it will be some sort of link. instead of the button. and if you have decided to make the header fixed , try to make the nav bar fixed as well so it will better. Also check out on the html report. include and alt tag on the image elements. Good Luck in other challenges as well.

  Marked as helpful

  0

  ---

  

  Kathryn•320

  @KathrynDavies123Posted almost 2 years ago

  @Yehan20 Hi Yehan, thanks for the advice. I agree a tags make more sense in this situation!

  Do the icons need alt tags? I was told in another solution feedback that if they are "meaningless" icons, they should not have them.

  Thanks

  1

  

  Yehan Nilanga•670

  @Yehan20Posted almost 2 years ago

  @KathrynDavies123 as far as i know having alt tags for images would be fine , i dont think an icon need an image tag

  0
• 

  yishak abrham•2,150

  @yishak621Posted almost 2 years ago

  i cant scroll down maybe because u set height100vh or something change it to min-height so that the overflow can be set as scroll and also in the mobile version the dropdown links shouldnt have any background color so fix that beside everything is good i love the transitions

  Marked as helpful

  0

  ---

  

  Kathryn•320

  @KathrynDavies123Posted almost 2 years ago

  @yishak621 Thanks! I think I had some unwanted scrolling earlier on and put in overflow hidden and forgot to take it out. :)

  1