Design comparison
Solution retrospective
I've already done this challenge before, but as it was included in the Learning path of Frontend Mentor I've done it again.
I'm happy with the time that it took me to complete this challenge compared to the last time, and also the small accessibility adjustments that I've done like role="presentation"
on images that have decorative puposes.
I've encountered some styling issues with the rating buttons as I gave them some padding
and also some width
and height
plus some gap
in the parent which made the card bigger than the
. The solution was to get rid of the gap
and the padding
and instead keep the width
and height
and add justify-content: space-between
in the ``.
I would appreciate any feedback. 👍
Community feedback
- @webdevbynightPosted 13 days ago
Some feedback:
- when applying
display: none;
to aninput
element, this element will not be rendered by screen readers at all (if you want it to be visually hidden, you can use your.visually-hidden
class); - about your
.visually-hidden
class, theclip
property is deprecated and you should use theclip-path
property instead (I let you check it on MDN for further information about it); - the hover effect on the labels should also be available when using the keyboard, so that a user unable to use a mouse can see which option is being chosen when the focus is on the radio buttons, provided they are not hidden with
display: none
(try to apply the CSS declarations within the&:hover
rule to a rule with a selector likeinput:focus + .radio-check
); - since you used an empty
alt
attribute to your decorative image, you do not need to addrole="presentation"
; - you should avoid using pixels to set font sizes (this video on YouTube explains why).
I hope this feedback helps you.
Marked as helpful0 - when applying
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord