
Design comparison
Solution retrospective
This challenge is not perfect and still needs some improvements, but the result so far is very nice, I will improve the responsiveness and the functioning of the ranking, but in general, I liked the first result.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @arjunbirsingh
Great work with the animation. However, your feedback.html always gives a rating of 4/5 no matter what is selected on the previous page. You can use localStorage or some other alternative for displaying the correct rating.
Marked as helpful - @0marD
Great job, well done! Just adjust the borders and width of the card. In its mobile version, it appears too large, and some borders are not clearly defined. I recommend using variables for frequently repeated styles, such as colors. The default height is automatic, but if you want to adjust it, you can use the "aspect-ratio" property. Regarding the card's width, I suggest using relative width with absolute min-width and max-width values. Lastly, avoid using the "!important" flag; it's considered bad practice. I have never encountered a situation where its use is justified. Best regards.
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord