Design comparison
Solution retrospective
This is my first time using inline svgs. I initially retained the fill property and discovered that hovering on spaces within the icon will not show its hover state. Only workaround I saw was to target the svg tag on the css file and declare initial and hover states for its fill property. Is this the standard?
Not sure what's going on with the screenshot...the live version doesn't show three lines of text in the CTA section in any screen width. I haven't coded in a while and I'd appreciate any comments for improvements or anything I've missed. Thank you!
EDIT: Took a new screenshot as updates to the platform were just pushed š Thanks Matt!
Community feedback
- @markup-mitchellPosted about 4 years ago
Hi Emmilie,
Inline SVGs can be targeted and styled with CSS just like HTML elements so you shouldn't think of the way you've done it as a workaround!
Leaving properties like
fillin the SVG will override the CSS in the same way as an inline style will override CSS, so yes, that's the way to do it. You might want to make the SVG width and height 100% and define those properties in the CSS class as well, just so you're not hard-coding those values into the markup.3@emestabilloPosted about 4 years ago@markup-mitchell Exactly the kind of answer I was looking for š Thanks so much!
0 - @mattstuddertPosted about 4 years ago
Awesome work on this challenge, Em! Seems like your questions have already been answered, so I'll just say you've done a really good job! š
Great that the new screenshot is a more accurate representation of your solution. Feels great to have that update live on the site!
1@emestabilloPosted about 4 years ago@mattstuddert Thanks Matt! And thanks for all the awesome new features on the platform š
0 - @ApplePieGiraffePosted about 4 years ago
Wow, amazing work, Emmilie Estabillo! š
I really like your solution! š
Happy coding! š
1@emestabilloPosted about 4 years ago@ApplePieGiraffe Thank you! Looking forward to yours š
0 - @Dark-LoverPosted about 4 years ago
hey,great job ;) . im working on the same challenge. the only issue that i didnt like in ur work is when u scroll while showing the nav-menu on mobile. i think u can fix that in just few lines, maybe a navbar position fixed.. something like that. good job ;)
1@emestabilloPosted about 4 years ago@Dark-Lover Will look into it. Thanks for the feedback!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord