Design comparison
Solution retrospective
Any feedback is appreciated :)
Community feedback
- @daniel-hennigPosted over 3 years ago
hey Tejas, I really like the simplicity of your solution from desktop to mobile layout design. In fact, I had an responsive image issue (with the paddern) on my own Insure-LP-solution and I could solve this problem, because of your solution. Regarding to your solution, I can find two issues on the layout from 900px and below. First: Between the family-image and the intro-details is like a little white space. Maybe you can get rid off it by putting the family-image and the intro-details within one div (I had also the same issue in my solution) - if it's not working, let me know please. Second: After opening the hamburger menu, the menu isn't overlaying the full screen. Maybe my solution can help you there. All in all, I can understand your code very easily, which I like.
Have a nice weekend :)
Daniel
0@Tejas-117Posted over 3 years ago@daniel-hennig Hey, thanks for the feedback.
I tried to remove the space between image and next div, but couldn't find the solution. And I didn't notice the issue regarding the hamburger menu. Thank you for the suggestions, I will update the solution as soon as possible and let you know.
-Happy coding :)
0@daniel-hennigPosted over 3 years ago@Tejas-117 you're welcome :)
I looked at your code again in order to solve the white space issue. With my div-suggestion it's not working, but easier than that, you can just add a little bit of negative margin-bottom to your family-image within the media query of 900px and below (so that you don't have that negative margin within the other layouts).
0@Tejas-117Posted over 3 years ago@daniel-hennig Yep, negative margin worked. It might take some time to reflect in the solution.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord