I used html and css to complete this qr-code-component challenge

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered correctly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states, Just add the following style rule

  ---

  body {
      display: grid;
      place-items: center;
      min-height: 100vh
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .qr-code-component {
     margin: 100px auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  • In order to center the card correctly, you can add flexbox and min-height: 100vh to the body
  • If you want, you can use the recommended color for the background of the screen

  body {
    /* background-color: hsl(220, 15%, 55%); */
    background-color: hsl(212, 45%, 89%);  /* the recommended background-color */
    display: flex;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
  }
  

  • after adding them, you don't need to use margin in the .qr-code-component to center the card:

  .qr-code-component {
    max-width: 230px;     /* max-width makes it responsive */
    /* margin: 100px auto; */
  }
  

  Hope I am helpful. :)

  0