I used flexbox and sass just for practice

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  In order to fix the accessibility issues:

  • You need to replace <div class="card"> with the <main class="card"> tag and <div class="attribution"> with the <footer class="card">. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
  • Each main content needs to start with an h1 element. Your accessibility report states page should contain a level-one heading. So, you need to use a <h1> element in the <main> tag instead of using <p>. You can replace your <p class="titulo">Improve your front-end skills by building projects</p> element with the <h1 class="titulo">Improve your front-end skills by building projects</h1> element.

  Hope I am helpful. :)

  Marked as helpful

  0

  ---

  

  Lissett Leal•40

  @lisslealPosted over 1 year ago

  Thanks for the comment @ecemgo It was my first frontend mentor challenge I didn't even consider accesibility 😯 I"ll keep it in mind from now on

  1

  

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  @lissleal no problem, happy coding! :)

  0