I finished QR code component by using VScode IDE and Google Chrome.

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  In order to fix the accessibility issues:

  • You need to replace <div class="ContentContainer boxProps flex-column center"> with the <main class="ContentContainer boxProps flex-column center"> tag and <div class="attribution"> with <footer class="attribution">. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
  • Each main content needs to include at least h1 element so you should use one <h1> element in the <main> tag. You can replace your <h3>Improve your front-end skills by building projects</h3> element with the <h1>Improve your front-end skills by building projects</h1> element.

  After committing the changes on GitHub and you need to deploy it as a live site. Finally, you should click generate a new report on this solution page to clear the warnings.

  Hope I am helpful. :)

  Marked as helpful

  1

  ---

  

  Sonsawan Ngamsom•140

  @murphy6867Posted over 1 year ago

  @ecemgo I forgot a lot of thing, You've remind me the importance thing!, Thank you.

  1

  

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  @murphy6867 happy to help! :)

  0
• 

  Dinesh Kumar T•100

  @dineshjrPosted over 1 year ago

  Please make your component inside the main tag which will be helpful for code accessibility and your solution is also not perfect while comparing it with the image file and kindly mobile view issue also.

  Thanks & Regards Dinesh

  Marked as helpful

  1

  ---

  

  Sonsawan Ngamsom•140

  @murphy6867Posted over 1 year ago

  @dineshjr thanks a lot :D

  0