huddle-landing-page-with-curved-sections

Community feedback

• 

  Amir Jacobs•165

  @Amir-JacobsPosted almost 4 years ago

  Hi Karim

  I took a quick look and I have some suggestions:

  • I'd stop using <br> to create space between elements. Instead, use margin or padding.
  • Your indentation could be improved -- perhaps look at how a code beautifier would indent your code.
  • In some cases I see inline-styling (such as <h1 style="font-size: 65px">2.7m+</h1>. I would put all styling in your CSS file instead.
  • Your class names and id's could be more descriptive. It's difficult to immediately tell what #final or #final2 is.
  • You also have some html and accessibility issues (there's a report of it on this page).

  You're on the right track. 😄

  2

  ---

  

  Karim•810

  @Karimsamir112Posted almost 4 years ago

  @Amir-Jacobs yes I understood , thanks you so much

  0
• 

  Arsh Karpoor•940

  @ArshKarpoorPosted almost 4 years ago

  99% Perfect 👌

  This is very nice

  But I have one 1️⃣ suggestion:-

  You can use fonts from styleguid.md

  2

  ---

  

  Karim•810

  @Karimsamir112Posted almost 4 years ago

  @ArshKarpoor ya okay , thanks you

  0