Design comparison
Community feedback
- @danielduduPosted over 3 years ago
Hi Grace,
Thank you for your comments that I very much appreciate. I modified the social part transforming them into links and removed the "hidden" problem and also fixed the width & height.
Regarding the white surround - I was induced in error by the picture of desktop preview mockup - so I designed according to it first. Now, I have changed somehow to appear as a full webpage.
Thanks again for your observations! :)
0 - @grace-snowPosted over 3 years ago
Hi
I'm not sure why this is shrunk down with a white surround? It's meant to be a full webpage.
The other thing I'm confused by in the html is the social icons. Usually those would be inside labelled links, but they are just images that are hidden from screenreaders at the moment, leaving an empty list of items to be announced by screenreaders. The icons also need a width and height so they don't get squished / distorted.
I hope that helps
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord