Design comparison
Community feedback
- @DrainGKPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
I have other recommendations regarding your code that I believe will be of great interest to you. HTML 🏷️:
This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to incorrect usage of semantic markup, which causes lacking of landmark for a webpage So fix it by replacing the wrapper <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page. What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers For example: The <main> element should include all content directly related to the page's main idea, so there should only be one per page The <footer> typically contains information about the author of the section, copyright data or links to related documents. .
You can also use "display: grid", or a display flex inside your main section with a part "left and right with different width" Do not forget about the margin and the color white for the sns icons.
- A border with a border radius at 50 percents I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord