Huddle Landing Page using scss

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Dinesh! 👋

  Good job on this challenge! Your solution responds well, here's my few tips:

  -- Since your .logo, .imgContainer, .imgCont images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers.

  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
  • You forgot to add this bluish background for .growTogether and .yourUsers.
  • Add some aria-label for your .followLinks links. This attribute is used to define a string that labels the current element. In your case these anchors have icons inside so screen readers users won't know what it is.

  Good luck with that, have fun coding! 💪

  2

  ---

  

  Dinesh•1,115

  @Dinesh1042Posted over 3 years ago

  @tediko Yep!.😊 Thanks for your feedback. I have read the article the and learned something new about the :focus pseudo class Thanks for your article suggestion. and I missed the bluish background in the sections.

  Yep! Thanks for your feedback! 😊 Happy Coding!😍

  0
• 

  Bonrey•1,130

  @BonreyPosted over 3 years ago

  Hi, Dinesh! I think you've done a bang-up job on this challenge: everything looks good and responds very well. Kudos! 😄

  There is one little thing that needs fixing, though: font-family of your input and button elements is set to Arial instead of Open Sans. The thing is, form elements don't inherit font settings from the body tag. So, you should set them manually. You can read about it in more detail here.

  Other than this, everything looks great. So, I can only wish you good luck with your coding! 🍀

  1

  ---

  

  Dinesh•1,115

  @Dinesh1042Posted over 3 years ago

  @Bonrey Yep! 😊 Thanks for your feedback. I have missed the input and button elements font-family . I will make sure to set font-family manually in my projects.

  Happy Coding! 😍

  1

  

  Bonrey•1,130

  @BonreyPosted over 3 years ago

  @Dinesh1042 you're welcome! And happy coding, too! 😸

  1