Design comparison
Solution retrospective
really fun challenge, i would love to ear some other way to attach the borders to the ain sections with much ease
Community feedback
- @tedikoPosted over 3 years ago
Hello, Luis! 👋
Good job on this one! 🎉 Your solution responds well and overall looks good. Here's my suggestions:
- Your wave backgrounds doesn't stretch on bigger resolutions (like. 1920x1080 in my example).
- Set a
max-width
on the container and center it horizontally so the content of the page doesn't look too stretched on large screens. - Add
:focus
pseudo class to interactive elements like anchors, buttons etc. Useoutline
property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default:focus
pseudo class withoutline
property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
Good luck with that, have fun coding! 💪
3@Comet466Posted over 3 years agoHi @tediko always nice to hear from you.
yeah the background images are set to the fixed width that they came with, i selected then and set the "background-size" property with a relative unit, it should look good now in your resolution too
also set a media querie with a min-width:1500px, and declare a fixed width for the images that should help with the stretch in bigger screens
i need to work in my accesibility for keyboard users, thanks and happy coding
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord