hitmorecode• 6,230
@hitmorecode
Posted
I took a look at your markup and css and there are a few thing you can fix.
- Change
h2toh1every page needs one h1. - You used
<br>to break text lines. Avoid doing this if it's not necessary, which in this case it's not. - Make it good practice to structure your html markup like this
<body>
<main>
/* place everything in here */
</main>
</body>
You have not font family loaded. Go to google fonts search for the fonts you need and import them
@import url("https://fonts.googleapis.com/css2?family=Open+Sans&family=Poppins:wght@400;600&display=swap")
/* this is a simple css reset. make it a habit of always using css reset in your css. if you want to learn more about css reset, do some google search */
* {
margin: 0;
padding: 0;
box-sizing: border-box;
}
body{
font-family: Poppins, "Open Sans"; /* add this line */
color: white;
background: hsl(257, 40%, 49%);
background-image: url(images/bg-desktop.svg);
background-position: center;
background-size: cover;
background-repeat: no-repeat;/* add this line, prevents image repetition */
min-height: 100vh; /* add this line */
}
@media (max-width:1200px) {
/* if you add this it will make the page responsive. you still need to fix the rest to make it look good. I'm just giving you a starting point */
.container {
display: flex;
flex-direction: column;
width: 1000px;
}
Marked as helpful
0
Big-Norj• 100
@Kingnorj1
Posted
@hitmorecode Thank you so much, i will do the changes needed
0
