Design comparison
Solution retrospective
This is my first challenge on Frontend Mentor. I'm still trying to figure out good coding practices (i.e. how to best structure my HTML/CSS; I believe my styles.css
is pretty messy, but I don't know how to go about tidying it) and understand flexbox. I still have many areas for improvement, so any feedback is much appreciated.
Thank you!
Community feedback
- @skyv26Posted almost 3 years ago
Hi! Guek, just as I saw you made it really good and it is responsive too, I didn't find any error. But as I can see in your report there are 4 accessibility error and here you can easily resolve your issue.
Just wrap your .card class div and .attribution class div inside <main></main> tag and your issue will then resolve successfully.
I hope this will work and useful for your future work in order to get 0 accessibility issue.
Good Luck
Marked as helpful1 - @HarishPRKPosted almost 3 years ago
Your project looks very good!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord