Design comparison
Solution retrospective
Nice challenge where I tried to write clean markup and style as close as possible to design.
Of course, it is not perfect, but it feels good to give it a try.
Any comments & observations are highly appreciated :)
Thank you all and happy coding!
Community feedback
- @vanzasetiaPosted over 3 years ago
👋Hi Daniel Dudu! My name is Vanza!
I have a feedback on this solution, if you open the dev tool and set the width of this page into 360px, now as you can see that the
header .logo
andbtn-header
are too big and so close to each other. Try to reduce the size of the logo and decrease thepadding
on thebtn-header
.That's it! Hopefully this is helpful!
Marked as helpful1@danielduduPosted over 3 years ago@vanzasetia Hi, Vanza Setia!
Thank you for your observation. I added a media query for screens with smaller withds than 350px for this issue.
0 - @grace-snowPosted over 3 years ago
Hi Daniel
This looks fairly good overall, but there are some differences to the design. Try to get it closer in all the smaller details like alignment, sizes and line-heights. If you look at the preview above you should start to see those differences
The only thing I would consider doing to deviate from the supplied design is that I would increase some font sizes a bit as they are very small in the design and hard to read. (That's the kind of thing you raise and discuss with a designer in real workplaces and usually they just adjust the design, but that's obviously harder here!) 😂
Good luck
Marked as helpful0@danielduduPosted over 3 years agoHi Grace, thank you for your comment. I've made some tweaks as to get a more closer view to the original.
The ideea with font sizes it is worth noted and definitely I will give it a try for the next challenge. :)
Al the best!
0 - @Amanpatil-DevPosted over 3 years ago
Great job Daniel 👌👌
Everything looks good and respond well 👍👍
0@danielduduPosted over 3 years ago@Amanpatil-Dev, Thank you :)!
All the best for you!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord