HTML5 & CSS3

Community feedback

• 

  T

  Grace•31,250

  @grace-snowPosted over 3 years ago

  Hey

  Looks good, well done!

  Don't forget to change the heading text-transform to uppercase, tweak the button radius a bit more and give your component a max-width to stop it getting too wide.

  Good luck

  0

  ---

  

  T

  Grace•31,250

  @grace-snowPosted over 3 years ago

  Other tips from looking at your code

  • it's usually best to only have one h1 per page
  • if youre going to scale down the base font size on html, you need to make sure you scale it straight back up again in rem on the body element to ensure font remains legible to those with different zoom settings
  • you really need to tidy up the css media queries. I can't tell. If you are trying to do mobile or desktop first and some of the media queries are overwriting each other at the moment. I recommend have all the mobile styles as your base and only override what you need to in min-width media queries for larger screens.

  Good luck

  0

  

  Daniel Dudu•380

  @danielduduPosted over 3 years ago

  @grace-snow thank you for your review - I have changed according to your observations :)

  About the media queries, I used Saas (using @media nested where I needed) and maybe that's why they appear fuzzy. I started with mobile design first.

  0

  

  T

  Grace•31,250

  @grace-snowPosted over 3 years ago

  @danieldudu it's not that, if you look. At your compiled css you'll see styles that are overwriting each other for the same. Media query

  0
• 

  Aman Patil•885

  @Amanpatil-DevPosted over 3 years ago

  hello daniel, everything looks good on your solution just a little tweek make sure your add width to class suv,sedan,luxury when you go above 1024px of maybe 30rem

  0

  ---

  

  Daniel Dudu•380

  @danielduduPosted over 3 years ago

  Thank you.@Amanpatil-Dev, I have tweaked accordingly :)

  0

  

  Aman Patil•885

  @Amanpatil-DevPosted over 3 years ago

  @danieldudu most welcome 👍

  0