Submitted over 1 year ago
HTML with a lot of divs and CSS that looks like spaghetti
@llr3v0ll
Design comparison
SolutionDesign
Solution retrospective
Any advices for future projects?
Community feedback
- @ecemgoPosted over 1 year ago
Some recommendations regarding your code that could be of interest to you.
In order to fix the accessibility issues:
- You need to replace
<div class="wrapper">
with the<main class="wrapper">
tag and<div class="attribution">
with the<footer class="attribution">
tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly. - Each main content needs to include at least h1 element so you should use one
<h1>
element in the<main>
tag. You can replace your<p class="title">Improve your front-end skills by building projects</p>
element with the<h1 class="title">Improve your front-end skills by building projects</h1>
element.
After committing the changes on GitHub and you need to deploy it as a live site. Finally, you should click generate a new report on this solution page to clear the warnings.
Hope I am helpful. :)
Marked as helpful0 - You need to replace
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord