html, sass, vuejs

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Elise Rousseau! 👋

  Nice work on this challenge! 🙌 Your solution looks pretty great! 👍

  Simply follow emestabillo's helpful suggestions and I think you'll be good to go! 😀

  One other tiny thing I noticed is that the elements in the form "jump" a bit when one of the form elements is focused (I think that's due to a border being added to the focused form element, slightly increasing its width and height and therefore causing the other elements to be pushed away just a tiny bit). You can get rid of this behavior by adding an invisible border around the form elements and simply changing the color of those borders when the form elements are selected. 😉

  Keep coding (and happy coding, too)! 😁

  0

  ---

  

  Elise Rousseau•685

  @SarahHenriettePosted almost 4 years ago

  Hey, @ApplePieGiraffe :-D,

  Thank you very much !

  Thank you also for your remark and your solution for the problem you have highlighted

  I would apply the advice you and emestabillo gave me :-)

  thanks again :-D

  0
• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted almost 4 years ago

  Hey Elise, congrats on this project! Looks exactly like the design. Just noticed a few things.

  • I'm getting a horizontal scrollbar around 600-690px

  • The form needs a little adjustment:

    • It is using both the default and JS validation. Perhaps adding novalidate will leave the validation solely to Javascript

    • If the email input is empty, both errors for empty and invalid are shown

    • If the email format is invalid, the native error message is shown

    • If the email format is invalid and the other two fields are empty, there are no error messages for the two empty inputs

  • There's also a few things to address in the accessibility report

  Hope this helps :-)

  0

  ---

  

  Elise Rousseau•685

  @SarahHenriettePosted almost 4 years ago

  Hello Emmilie :-),

  Thank you for your very insightful comments :-) . It helps me a lot.

  I admit I still have trouble with the forms !

  Thank you again for your help :-)

  0