html, css vanilla project | easy to do 10 min work

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

  ---

  • So fix it by replacing the <div class="main"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  HTML

  In order to fix the accessibility issues:

  • You need to replace <div class="main"> with the <main> tag. You'd better use Semantic HTML, and you can also reach more information about it from Semantic HTML.

  CSS

  • In order to center it correctly, you can use this style:

  body {
     display: flex;
     justify-content: center;
     align-items: center;
     min-height: 100vh;
  }
  

  instead of using this style from your .main class in CSS and you can remove this style from there:

  .main {
     height: 100vh;
     min-height: 600px;
     display: flex;
     justify-content: center;
  }
  

  Hope I am helpful. :)

  0