html, css, html5, css3

Community feedback

• 

  Shivangam Soni•990

  @ShivangamSoniPosted over 1 year ago

  Hi, Congratulations on Completing the Challenge

  Here are a few suggestions that might help you:

  • You are separating the image & the text content using section tags. The problem with this is that screen readers will see those as two separate landmarks. Whereas it's suposed to be one single component where the text content basically gives details about the product in the image. I would recommend using a single section tag for grouping the image & content, and put the image & content itself within divs.

  <section>
  // Image Div
  // Content Div
  </section>
  

  • You have asked about 50-50 split, to do that you are using flex but grid would have been a much easier solution.

  display: grid;
  grid-template-columns: repeat(2, 1fr);
  

  Marked as helpful

  1

  ---

  

  Hisham Abdelalem•150

  @HeshamAbdelalemPosted over 1 year ago

  Thanks @ShivangamSoni for your time and your suggestions

  1