HTML and CSS

Community feedback

• 

  Dušan Lukić•1,660

  @dusanlukic404Posted about 3 years ago

  Hi Stephane, well done! You make great solution for this challenge 😃 I have a few suggestions for you:

  • Always add :hover and :focus on buttons and links. You need it here and also add later some transition to make hover smooth and nice
  • Try to add some hover animation on social svg's. I suggest you to take a look on my solution and see how I have done it. It may be useful 🙂
  • For <a> tags you need to add aria-labels

  Check your accessibility and HTML issues. They are pretty important these days

  Marked as helpful

  0

  ---

  

  Stephane Jean•360

  @distephano30Posted about 3 years ago

  @dusanlukic404 Thank you Dusan, I added some hover, and the aria-label on the links. You did an awesome Job on your Solutions. It's really good.

  0
• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted about 3 years ago

  Hey, well done on completing this challenge, your solution looks good on most screen sizes! I'd only add a couple of things you could improve on:

  1. Hover states are missing.

  2. The text/buttons are extremely small in desktop view, go for something larger to make it a bit easier to read.

  3. You're missing some aria-labels on your social icons.

  Marked as helpful

  0

  ---

  

  Stephane Jean•360

  @distephano30Posted about 3 years ago

  @FluffyKas great thanks! I will try this

  0