Skip to content
Submitted about 3 years ago

HTML 5, SASS, JS

ThanhVuong0904•465
@ThanhVuong0904
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Bookmark landing page
  • HTML
  • CSS
  • JS
3intermediate

Design comparison

SolutionDesign

Solution retrospective

Hope you like this solution. Please tell me if there is something to improve in my code. Thanks you

Community feedback

  • Dharmik_487•1,740
    @Dharmik48Posted about 3 years ago

    Hey👋,

    Great Job on completing the challenge! It looks really good! But there's one thing I found that you need to improve on which is:

    • You are using the absolute unit px for almost everything which is not a good practice! Instead using relative units like em and rem is suggested! It makes it easier to make the site responsive. Read this article to learn more.

    Keep Developing🤗👍.

    0
    ThanhVuong0904•465
    @ThanhVuong0904Posted about 3 years ago

    @Dharmik48 Hi ! Thanks you for feedback, I will learn more about "em" and "rem". Have a good day <3

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord