Design comparison
SolutionDesign
Solution retrospective
accepting feedback specially the image background suggestions
Community feedback
- @tedikoPosted almost 4 years ago
Hello, Harold! 👋
Good job on this challenge! Your background solution seems okay. It only needs small changes.
- Try work with
background-size
andbackground-position
of your background to fit design. You set size to 100% and in design they're much smaller, then position them once again. <hr>
element represents a thematic break between paragraph-level elements. Maybe addborder-bottom
to.profile
div element instead. That way your solution will be closer to design.
Good luck with that, have fun coding! 💪
1 - Try work with
- @ApplePieGiraffePosted almost 4 years ago
Hey, Harold! 👋
Good job on another challenge! 👍
I'd like to suggest using flexbox to center the card component in the middle of the viewport (rather than using a bunch of margin/padding-top) so that it remains in the center even when the screen is resized. Or you could use
margin: auto
to do the same thing, if you'd like!Keep coding (and happy coding, too)! 😁
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord