Grid testimonials by Thomas Hertog

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted about 3 years ago

  Hi Thomas,

  I suggest using figure with blockquote and figcaption for these testimonials instead of sections. I don’t think you need the screenreader only headings on the testimonials

  And make sure the strong paragraph is inside an actual paragraph. Strong is an inline element designed to be used inside a paragraph, not on it’s own

  Similarly, the people’s names and verified shouldn’t just be in divs. If you choose not to go down the figcaption route, I would make the names into headings.

  On the images “profile pic” is not good alt text. That needs to be the person’s name. A general tip is you never need words like image/picture etc inside an alt attribute as the element is already announced as an image.

  I hope this is all helpful

  Marked as helpful

  0

  ---

  

  Thomas Hertog•825

  @thomashertogPosted about 3 years ago

  @grace-snow I read up on MDN about figure and blockquote and adjusted. Good suggestion.

  As for the profile pictures, I was still in doubt and after reading Jakes (Archibald) article about "Writing great alt text", I decided to hide the profile pictures from assistive technologies as they don't really add that much value (unless there was an elaborate description on the picture which I can't think of)

  0

  

  T

  Grace•31,270

  @grace-snowPosted about 3 years ago

  @thomashertog yep that's definitely a fair point ☺ I think it's valid to hide these images from assistive tech in this case, or use the person's name as the alt text. Either way works fine

  0
• 

  dewslyse•3,025

  @dewslysePosted about 3 years ago

  Hello @thomashertog! Congrats on your submission. You need to set a max-width on your main to prevent the testimonial grid from spanning the full width of the page. A width of 69.375rem should suffice. After setting the max-width, you'll need to add justify-content: center to the body so that the grid will be centered on the page. Happy coding!!

  1

  ---

  

  Thomas Hertog•825

  @thomashertogPosted about 3 years ago

  @dewslyse done, although I went with a bigger max-width

  0