Djamel1133• 150
@Djamel1133
Posted
Hi, I'm not an expert, but I noticed a few points that might help improve your code:
Your main div doesn't contain all your elements because you fixed the height at 70%. I suggest removing this height restriction. You can remove the profileimg div and keep only your image with the class img.
For height and width properties, it's preferred to use em or rem units, like this: height: value in rem; width: value in rem; for more details see : Why font-size must NEVER be in pixels.
To get a full page without scrolling, you can set the dimensions of your main div as follows: height: 100vh; width: 100vw; (but not in the body)
You should use .buttonlink:hover instead of .buttonlink:active. Good job and keep it up!
0
