Fylo-Storage-Component

Community feedback

• 

  Eric Karugu•210

  @erickaruguPosted almost 3 years ago

  Hi Naveen👋,

  Good job! I love your solution. It looks great.

  Happy coding 💻!

  Marked as helpful

  1
• 

  Martin•460

  @nonso01Posted almost 3 years ago

  f**😂😂! I had to check your code this challenge has been given me some headache! am gonna check again! nice work dude📸🔥

  1

  ---

  

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  @nonso01 Thanks man!

  0
• 

  Candela Bramucci•680

  @bramuccciPosted almost 3 years ago

  Hi Naveen! Awesome solution, I love it. I just had a question, why do you choose using ::after instead of brackground-image? Is it more easy that way or have something to do with accessibility?

  1

  ---

  

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  @bramuccci It was just trial and error thing 😅 *i saw it somewhere and tried it worked 😊

  1
• 

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted almost 3 years ago

  I think your design looks good on desktop but not responsive on mobile

  0

  ---

  

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  @Kamasah-Dickson I have make media query for 375px

  0

  

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted almost 3 years ago

  @Crazimonk okay but your footer is overflowing the card...am viewing your solution on a mobile

  Try removing the position property on the footer But But maintain the footer being at the center and add margin-bottom maybe 1em on the card in mobile view

  Let's see the result

  Marked as helpful

  0

  

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  @Kamasah-Dickson sure i will fix it later thank you 😊

  0
• Account deleted

  Hi there 👋

  You did a great job 👏. I think it would be great to add some box-shadow to both cards.

  About your code, I teach a nice tip to center div with clean code. 😉

  Replace this your code with my code inside the body selector

  display: flex;
  flex-direction: column;
  align-items: center;
  justify-content: center;
  

  My code - don't worry I have tested and it didn't break your design 👍

  display: grid;
  place-items: center;
  

  Happy coding ☕

  0

  ---

  

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  @maqsudtolipov

  display: flex; flex-direction: column; align-items: center; justify-content: center;

  I removed these four and added

  display: grid; place-items: center; your code!

  and it didn't work

  0

  Account deleted

  @Crazimonk Are you using chrome, it's working still, maybe because of a different browser. Otherwise, you can use your old code 😉

  0

  

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  @maqsudtolipov yes i am using chrome

  0

  Account deleted

  @Crazimonk Maybe watch this video. I learned it from there: link

  Marked as helpful

  0

  

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  @maqsudtolipov sure i will take a look

  0