Design comparison
Solution retrospective
Hi guys!! It has been quite a while now... I almost finished learning js. Just a few things left so I came back to practice my HTML and CSS :D Any feedback would be really appreciated!
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hello, Abbas Saad! π
Good to see you back (it has been a little while)! π And nice job on this challenge! π
I was just going to say almost the same things RayaneBengaoui mentionedβI like the animation you added to the progress bar and adding
cursor: pointer
to the options in the box to the left would be a good idea! πOf course, keep coding (and happy coding, too)! π
1@AbbasSaad27Posted over 3 years ago@ApplePieGiraffe HI APG. Yeah, it has been quite a while. I plan on doing challenges frequently like before. Thanks for the feedback mate! I'll soon fix that problem. Happy coding! :D
1 - @RayaneBengaouiPosted over 3 years ago
Hello Abbas Saad,
First of all, congrats for the challenge !
Your solution looks pretty clean and responsive for me ! If we want to be picky, I would just add a little
cursor: pointer
on your li tags to understand it's clickable. Also, adding some HTML semantic elements to ease code readability would be nice. (PS : Nice little keyframe !)Overall, well done for the challenge and happy coding ! π
1@AbbasSaad27Posted over 3 years ago@RayaneBengaoui Thanks a lot for the feedback mate! I was thinking if I should add cursor: pointer on li tags. But since they don't really do anything, I ended up not adding it on them. But you're right I should've added it. Thanks for the suggestion! Happy coding! :D
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord