Fylo solution with flexbox, absolute positioning

Community feedback

• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted about 4 years ago

  Hey Pierre, looks good! Just a few things here:

  • The component is touching the left and right gutter in medium widths up until the breakpoint

  • Icons could use cursor: pointer that suggests they are clickable

  • I would limit the use of ids for JS targeting or scroll links. They have a high specificity, meaning their styles are hard to override. Better to use classes.

  Hope this helps!

  2

  ---

  

  Pierre•215

  @pchatardPosted about 4 years ago

  @emestabillo Thank you for your comments ! I'll take a look into this and make some changes!

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hey, nice work, Pierre! 👍

  Your solution looks good and is responsive! 👏

  I suggest,

  • Allowing the background SVG to fill the entire area of the screen in the mobile layout of the site. Currently, some white space begins to appear at the top and bottom of the viewport at very narrow screen widths.
  • Perhaps decreasing the right-padding in the box with the option icons just a little so that all of the icons remain on one row (even right before the layout changes from desktop to mobile).

  Keep coding (and happy coding, too)! 😁

  1