@YuliaLantzberg
Posted
Heyyy. Looking good but there are some notes. *In HTML you put header inside main tag. Usually they are sibling tags and I don't see in this case why to change it. The header can absolutely be a separate element here without need of any outer container except body tag. *You haven't any spacing between the beginning of the page and the header element. *The quot icon is hidden behind the card. I guess z-index will resolve the problem or according to the original design you need to align it. (Tho I think with z-index it will look cooler) *The list in the footer is not aligned. It should be smth like flex-start and not center. *And there is a small bug with the hover effect when in mobile view, the button itself is growing unproportionally. Tbh, I don't know if it's your bug or of the browser. *The email check works perfectly *Why did you define the header effect only for screens greater than 1600? It will look great and useful also on smaller screens. But it's looking awesome anyway. *For me a bit hard to read code when the media queries are spread in between regular code and code is not structured as per the page or HTML structure. But, it's only my opinion and I guess it's more about personal preference. Hope it's somehow helpful.
Marked as helpful
@MikDra1
Posted
@YuliaLantzberg Thanks, for replay 😁
- I change main and header tag so they are sibling elements right now.
- I added some more spacing between header and beginning of the page. The photo is just not super clear.
- The quote on the design is behind the testimonial because this is how it was on the design. Now I see they might have changed it.
- The hover effect on mobile won't work if you start on mobile device. I added a load event to the window which checks whether if the loaded device screen width is grater then 1000 only then it works. So if you the resize the screen width with the devTools and you click on the button it will have this effect because your loaded screen size is more then 1000px. If you want to check this try opening the website on your phone.
- I changed the header effect so now it works across all screen widths
- Media queries are spread across whole code because of the SASS compiler. I add media queries to all elements and not just in one file at the end. And that's why media queries are all over the file 🤗
@YuliaLantzberg
Posted
@MikDra1 Thnx for explaining. I saw that you set the 1000px boundary but couldn't understand why it's still visible in the devTools. Now I got it
