Fylo data storage component using html and css

Community feedback

• 

  negative843•90

  @negative843Posted over 3 years ago

  thamnks for review. i am trying to learn flexbox and responsive design

  0
• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted over 3 years ago

  Hi @negative843, both the design and images folder are missing from your repo, and the latter contains the logo. If you download the starter files again and upload the folders, you'll be able to use the logo.

  Code-wise, good effort, but I think the project has a bit more to go before achieving RWD. I suggest taking Grace's advice from your 3-column card project and applying it here, particularly: using rems vs px, styling with classes not ids, and good use of flexbox. Avoid hard-coding heights and widths unless necessary, since it can introduce problems such as horizontal scroll like we see here. Same thing with absolute positioning - box1 and box2 didn't need to be absolutely positioned. Semantics need to be edited as well, for example, those boxed images should be clickable like a button since they're likely be used to upload something on a real site. If you'd like to improve responsiveness of your design, here's one resource and another one.

  Hope this helps!

  0