Fylo data storage component challenge hub

Community feedback

• 

  Dušan Lukić•1,660

  @dusanlukic404Posted about 3 years ago

  Hey Yasser, nice job congrats! I have a few suggestions for you:

  • Change background-size from initial to contain
  • You should have align-items: flex-end on your .cards
  • Make images on left card same size
  • Check accessibility and HTML issues on your solution so you can see and learn much more, they are very important

  Marked as helpful

  1

  ---

  

  yasser Abd Elghany•165

  @yasser22269Posted about 3 years ago

  @dusanlukic404 thanks , I will correct these errors now.

  0
• 

  T

  Mike Hayden•1,005

  @mickygingerPosted about 3 years ago

  Hi Yasser! 👋

  This is cool! I have a couple of small suggestions:

  The background image is cropped on larger screens. I'm not sure the best approach here, but I think that setting background-size: cover; background-position: 50vh; might make it look reasonable on most viewport sizes.

  If you set align-items: flex-end on div.cards the two panels will line up by their bottom edges which matches the design.

  The only other thing I would recommend is that you take a look at the progress element. It's not the easiest thing to style, but it makes sense semantically here.

  I hope that's useful! 🤓

  Marked as helpful

  1

  ---

  

  yasser Abd Elghany•165

  @yasser22269Posted about 3 years ago

  @mickyginger thanks , I will correct these errors now.

  0