Fully Responsive Testimonial Grid using CSS Flex and Grid

Community feedback

• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted about 4 years ago

  Hi @umi93, project looks good! No responsive issues. Here's a few things:

  • I think you could use more semantic html rather than using divs for the major blocks

  • Some of the text colors are slightly off, I think they are missing their opacity property

  The shadows also look a little heavy to me, maybe better with more spread - but this is just my preference. Great job!

  1

  ---

  

  Umar Bashir Rather•115

  @umarbashirrPosted about 4 years ago

  @emestabillo Thanks for your feedback. It really means so much to me. As I am learning to be a complete developer. Can you please tell me where should I use semantic tags. I will definitely do the changes as per your suggestion and will try to make it much better. Thanks once again.

  1

  

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted about 4 years ago

  @umi93 An example of better semantics would be using articles on the testimonial boxes instead of divs

  1

  

  Umar Bashir Rather•115

  @umarbashirrPosted about 4 years ago

  @emestabillo Thanks 😊. I will update the same.

  1