four-card-feature-section-master

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @UnderdogScripter 👋🏻

  I have just a quick tip to make the project more accessible

  • The icons, should have aria-hidden="true”, because they are for decoration only.
  • Just to keep the code cleaner, I suggest removing this part from HTML and putting it in the CSS file as well:

  .attribution {
      font-size: 11px;
      text-align: center;
  }
  
  .attribution a {
      color: hsl(228, 45%, 44%);
  }
  

  • And one last thing, instead of selecting items with just their tags or :nth-child(), I suggest giving them specific classes. You can read this to understand CSS specificity even better. Also, as a class naming convention I suggest studying BEM, it will also come in handy when you learn SASS.

  I hope this was helpful 👨🏻‍💻 Nice job on responsiveness, it seems like you got a pretty good hang of. Cheers 👾

  Marked as helpful

  1

  ---

  

  Mohamed-G•205

  @UnderdogScripterPosted about 3 years ago

  @kens-visuals Thanks for suggesting BEM, I'll make sure to implement it in my future projects (most of the challenges I'm uploading RN were made a while ago), thanks!

  1

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @UnderdogScripter no problem 😇

  0
• 

  Fidel Lim•2,775

  @fidellimPosted about 3 years ago

  Hi @UnderdogScripter,

  Great work on finishing the project! it looks great on desktop and mobile views! Also, your markdown of your HTML looks great.

  1

  ---

  

  Mohamed-G•205

  @UnderdogScripterPosted about 3 years ago

  @fidellim Really glad to see this coming out of a veteran like you, thanks!

  1