Four Card Feature using Sass

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Marco! 👋

  Well done! I really like what you have done here. You write good semantics in your HTML and also your BEM naming is on point.

  • Since you work with Sass, i recommend you to read about Sass 7-1 pattern to keep your file management orginazed. Maybe not for that small projects, but in bigger one it will be helpful.
  • Your card__img images are decorative so your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Marco•185

  @devMarco02Posted over 3 years ago

  thanks for the tips @tediko

  0
• 

  P

  Marko Nikolajević•1,065

  @MarkoNikolajevicPosted over 3 years ago

  Hi Marco

  You did a really good job on this challenge. Your solution is responsive and everything looks well.

  To make your solution looks more like the design, I would suggest to add a white background color on your cards

  Your code is clean and well documented with comments :)

  Keep on coding :)

  1

  ---

  

  Marco•185

  @devMarco02Posted over 3 years ago

  I added it. thanks @MarkoNikolajevic.

  0