Design comparison
Solution retrospective
Here is another challenge, again with some CSS grid layout. I really like the approach I took with the layout and also I gave it some cool animations let me know what you think about them!
Any other feedback about the solution is greatly appreciated!
Community feedback
- @dewslysePosted over 3 years ago
Hello!! Your submission is awesome. Nice touch with the entry animation. Pretty cool😎. Your page is also responsive across devices. For this challenge, I would have approached mid-level devices differently by serving them a two-column view of the cards rather than move straight from the desktop layout to the mobile layout.
Please check your html. There are more than one
h1
s. Best practice dictates oneh1
per page. You could keep one of the<header>
h1s and change the rest toh2
s andh3
s.Happy coding...
Marked as helpful0@B1N4R1Posted over 3 years ago@dewslyse You're right don't know why I go from desktop to mobile layout directly I'll definitely change that. Regarding your second comment, I saw the report said something about the h1s but didn't understand what it meant, so thank you for the aclaration I'll change that too.
Thanks for the feeback!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord