Not Found
Not Found
Not Found
Not Found
Not Found
Your session has expired please log in again.
Your session has expired please log in again.
Your session has expired please log in again.
Not Found
Your session has expired please log in again.
Not Found
Not Found
Your session has expired please log in again.
Not Found
Not Found
Not Found
Not Found
Your session has expired please log in again.
Not Found
Not Found

Submitted

Four card feature section (Responsive, Modular SCSS, BEM, Semantic)

Franco A. 200

@franco-a

Desktop design screenshot for the Four card feature section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello! For this project I tried to challenge myself by making my SCSS more modular using partials. The file architecture that I used is a modified 7-1 pattern. If anyone is familiar with it, I'd like to hear your feedback. Thank you!

Community feedback

P
tediko 6,680

@tediko

Posted

Hello, Franco A! 👋

Congrats on finishing another challenge! Your solution responds well. Glad you read about 7-1 pattern. You used it correctly. It seems cleaner, isn't it? Here's my few suggestions:

  • Add some padding to .feature__card-container (for example 0 24px) to make some room and to prevent your container to stick to borders when I resize window between mobile styles and desktop.
  • Instead of writing your media queries at the bottom of your style file, write media query inside every element you want to change. For example:
 &__paragraph {
        color: c.$gray-blue;
        font-weight: f.$fw-reg;
        font-size: f.$fs-m;
        margin-bottom: 76px;
        max-width: 540px;

        @media (min-width: 1025px) {
         something here
         }
    }

Good luck with that, have fun coding! 💪

2

Franco A. 200

@franco-a

Posted

Hey @tediko ! Thanks for the feedback. I'll be making changes using your suggestions

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord