Four card feature section (Responsive, Modular SCSS, BEM, Semantic)

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Franco A! 👋

  Congrats on finishing another challenge! Your solution responds well. Glad you read about 7-1 pattern. You used it correctly. It seems cleaner, isn't it? Here's my few suggestions:

  • Add some padding to .feature__card-container (for example 0 24px) to make some room and to prevent your container to stick to borders when I resize window between mobile styles and desktop.
  • Instead of writing your media queries at the bottom of your style file, write media query inside every element you want to change. For example:

   &__paragraph {
          color: c.$gray-blue;
          font-weight: f.$fw-reg;
          font-size: f.$fs-m;
          margin-bottom: 76px;
          max-width: 540px;
  
          @media (min-width: 1025px) {
           something here
           }
      }
  

  Good luck with that, have fun coding! 💪

  2

  ---

  

  Franco A.•200

  @franco-aPosted over 3 years ago

  Hey @tediko ! Thanks for the feedback. I'll be making changes using your suggestions

  0