Four card feature section challenge Using CSS Grid

Community feedback

• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted almost 3 years ago

  Hi Chris, congrats on your submission! Great job with responsiveness and code is well-structured, easy to understand.

  Grid: I would probably wait to use grid until the cards are laid out, since they will naturally stack anyway without grid. But that's opinion. I would also only use it for the cards. The heading text can be centered with text-align. A few more thoughts:

  • <header> can be substituted for div class="header"
  • Better to use span instead of h2 to style the second line on the heading. The appearance of the element in the design don't always determine the proper html tag needed.
  • At the 1100px breakpoint, the cards are touching the left and right gutters
  • I'd be mindful of hardcoding widths in px. Instead, use fluid properties (like max-width) and units (like rem)

  Hope this helps!

  Marked as helpful

  2

  ---

  

  Chris•250

  @chintriagoPosted almost 3 years ago

  @emestabillo I appreciate your advice it's very helpful thank you! :)

  1